[Prev][Next][Index][Thread]
Re: OSKit 20020317 snapshot; St. Patrick's Day Snapshot
I have two things to report. Both were already mentioned on the
list before (for older snapshots). First the 'sbrk-hack' building
problem. As it seems newer gnu/linux distros do not compile
oskit snapshots with the sbrk-hack. One way the solve this problem is
to remove the file:
rm oskit-20020317/unix/linux/sbrk-hack.c
--- /home/wagi/hurd/oskit-20020317.orig/unix/linux/GNUmakerules Tue Jan 25 10:25
:32 2000
+++ unix/linux/GNUmakerules Mon Mar 18 22:55:55 2002
@@ -21,7 +21,6 @@ _oskit_unix_linux_makerules_ = yes
SRCDIRS += $(OSKIT_SRCDIR)/unix/linux
UNIXLIB_OBJ += net.o socket.o
-NATIVECALLS_OBJ += sbrk-hack.o
include $(OSKIT_SRCDIR)/unix/elf/GNUmakerules
But I think the better solution will be to add a configure option.
The second problem is an obscure redefinition of GFP_ATOMIC. In
the orignal Linux code GFP_ATOMIC is defined as following:
#define __GFP_HIGH 0x08
[...]
#define GFP_ATOMIC (__GFP_HIGH)
But in oskit-20020317/oskit/io/skbufio.h it is redefined to
#define GFP_ATOMIC 0
My question is why is this needed? It introduces a bug as
far as I can say. Here is a patch for this:
--- /home/wagi/hurd/oskit-20020317.orig/oskit/io/skbufio.h Thu May 24 23:54
:08 2001
+++ skbufio.h Mon Mar 18 22:40:52 2002
@@ -425,7 +425,6 @@ skb_cloned(struct sk_buff *skb)
return iscloned;
}
-#define GFP_ATOMIC 0
static inline struct sk_buff *
skb_clone(struct sk_buff *skb, int priority)
Thanks anyway for your great work,
wagi
--
Daniel Wagner "Don't drink and derive."
email: wagi@gmx.ch
GnuPG: 1024D/DCDE890A (public key available on any keyserver)
Follow-Ups:
References: